Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Issue 365263004: Remove hit test mask methods from views::View (Closed)

Created:
6 years, 5 months ago by tdanderson
Modified:
6 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove hit test mask methods from views::View The definitions of hit test masks and related logic have beed moved into MaskedTargeterDelegate, so remove HasHitTestMask(), GetHitTestMaskDeprecated(), and the HitTestSource enum from views::View. BUG=388838 TEST=ViewTargeterTest.HitTestCallsOnView Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282779

Patch Set 1 #

Patch Set 2 : WIP #

Patch Set 3 : rebase against ToT #

Patch Set 4 : re-upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -169 lines) Patch
M ui/views/view.h View 2 chunks +0 lines, -27 lines 0 comments Download
M ui/views/view.cc View 2 chunks +1 line, -32 lines 0 comments Download
M ui/views/view_targeter_unittest.cc View 2 chunks +91 lines, -0 lines 0 comments Download
M ui/views/view_unittest.cc View 2 chunks +0 lines, -110 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tdanderson
Sadrul, can you please take a look? Note that the ViewTargeterTest.HitTestCallsOnView test is more-or-less just ...
6 years, 5 months ago (2014-07-10 20:46:02 UTC) #1
sadrul
LGTM
6 years, 5 months ago (2014-07-11 20:44:43 UTC) #2
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 5 months ago (2014-07-11 20:51:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/365263004/60001
6 years, 5 months ago (2014-07-11 20:52:54 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-11 23:48:08 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 02:23:05 UTC) #6
Message was sent while issue was closed.
Change committed as 282779

Powered by Google App Engine
This is Rietveld 408576698