Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: ui/views/view.h

Issue 365263004: Remove hit test mask methods from views::View (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: re-upload Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/view.h
diff --git a/ui/views/view.h b/ui/views/view.h
index b0340ea14fbe07ba0c59ffdc57de8f6ea4b0bbec..1bdee37cdbbaf3360fe8673a4ed79e3afcd9746b 100644
--- a/ui/views/view.h
+++ b/ui/views/view.h
@@ -110,19 +110,6 @@ class VIEWS_EXPORT View : public ui::LayerDelegate,
public:
typedef std::vector<View*> Views;
- // TODO(tdanderson): Becomes obsolete with the refactoring of the event
- // targeting logic for views and windows. See
- // crbug.com/355425.
- // Specifies the source of the region used in a hit test.
- // HIT_TEST_SOURCE_MOUSE indicates the hit test is being performed with a
- // single point and HIT_TEST_SOURCE_TOUCH indicates the hit test is being
- // performed with a rect larger than a single point. This value can be used,
- // for example, to add extra padding or change the shape of the hit test mask.
- enum HitTestSource {
- HIT_TEST_SOURCE_MOUSE,
- HIT_TEST_SOURCE_TOUCH
- };
-
struct ViewHierarchyChangedDetails {
ViewHierarchyChangedDetails()
: is_add(false),
@@ -1146,20 +1133,6 @@ class VIEWS_EXPORT View : public ui::LayerDelegate,
// Input ---------------------------------------------------------------------
- // Called by HitTestRect() to see if this View has a custom hit test mask. If
- // the return value is true, GetHitTestMask() will be called to obtain the
- // mask. Default value is false, in which case the View will hit-test against
- // its bounds.
- virtual bool HasHitTestMask() const;
-
- // Called by HitTestRect() to retrieve a mask for hit-testing against.
- // Subclasses override to provide custom shaped hit test regions.
- // TODO(tdanderson): Remove this method once Tab, TabCloseButton,
- // NewTabButton, and MicButton all implement
- // MaskedViewTargeter.
- virtual void GetHitTestMaskDeprecated(HitTestSource source,
- gfx::Path* mask) const;
-
virtual DragInfo* GetDragInfo();
// Focus ---------------------------------------------------------------------
« no previous file with comments | « no previous file | ui/views/view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698