Move options_util.* into chrome/browser/metrics.

chrome/browser/metrics/metrics_reporting_state.h

Index: chrome/browser/metrics/metrics_reporting_state.h
diff --git a/chrome/browser/metrics/metrics_reporting_state.h b/chrome/browser/metrics/metrics_reporting_state.h
new file mode 100644
index 0000000000000000000000000000000000000000..ae26f3bda25859fa66894b0d97f64024f3b6a4af
--- /dev/null
+++ b/chrome/browser/metrics/metrics_reporting_state.h
@@ -0,0 +1,12 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_
+#define CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_
+
+// Try to make the the crash stats consent and the metrics upload
+// permission match |enabled|, returns the actual enabled setting.

[Ilya Sherman, 2014/07/07 22:59:24]

This comment is pretty confusing.  I realize you're just moving the code, but
let's clean it up a bit along the way.  Here's a starting point; feel free to
improve further:

"""
Tries to set crash stats upload consent to |enabled|.  Regardless of success, if
crash stats uploading is enabled, starts the MetricsService; otherwise stops it.
 Returns whether crash stats uploading is enabled.
"""

[tfarina, 2014/07/20 02:44:32]

Done.

+bool ResolveMetricsReportingEnabled(bool enabled);

[Ilya Sherman, 2014/07/07 22:59:24]

Hmm, this method is pretty confusing.  It behaves similarly to something that
I'd call "SetMetricsReportingEnabled()", except that it doesn't actually set the
appropriate pref (which, admittedly, differs by platform... which is also
confusing).  Please add a TODO and/or file a bug to clean this up and rename the
method.

[tfarina, 2014/07/20 02:44:32]

Done.

+
+#endif  // CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_