chrome/browser/metrics/metrics_reporting_state.h - Issue 365253004: Move options_util.* into chrome/browser/metrics.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/metrics/metrics_reporting_state.h

Issue 365253004: Move options_util.* into chrome/browser/metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/chromeos/settings/device_settings_provider.cc ('k') | chrome/browser/metrics/metrics_reporting_state.cc » ('j') | chrome/browser/metrics/metrics_reporting_state.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_

	6 #define CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_

	7

	8 // Try to make the the crash stats consent and the metrics upload

	9 // permission match \|enabled\|, returns the actual enabled setting.
	Ilya Sherman 2014/07/07 22:59:24 This comment is pretty confusing. I realize you'r This comment is pretty confusing. I realize you're just moving the code, but let's clean it up a bit along the way. Here's a starting point; feel free to improve further: """ Tries to set crash stats upload consent to \|enabled\|. Regardless of success, if crash stats uploading is enabled, starts the MetricsService; otherwise stops it. Returns whether crash stats uploading is enabled. """ tfarina 2014/07/20 02:44:32 Done. Show quoted text On 2014/07/07 22:59:24, Ilya Sherman wrote: > This comment is pretty confusing. I realize you're just moving the code, but > let's clean it up a bit along the way. Here's a starting point; feel free to > improve further: > > """ > Tries to set crash stats upload consent to \|enabled\|. Regardless of success, if > crash stats uploading is enabled, starts the MetricsService; otherwise stops it. > Returns whether crash stats uploading is enabled. > """ Done.
	10 bool ResolveMetricsReportingEnabled(bool enabled);
	Ilya Sherman 2014/07/07 22:59:24 Hmm, this method is pretty confusing. It behaves Hmm, this method is pretty confusing. It behaves similarly to something that I'd call "SetMetricsReportingEnabled()", except that it doesn't actually set the appropriate pref (which, admittedly, differs by platform... which is also confusing). Please add a TODO and/or file a bug to clean this up and rename the method. tfarina 2014/07/20 02:44:32 Done. Show quoted text On 2014/07/07 22:59:24, Ilya Sherman wrote: > Hmm, this method is pretty confusing. It behaves similarly to something that > I'd call "SetMetricsReportingEnabled()", except that it doesn't actually set the > appropriate pref (which, admittedly, differs by platform... which is also > confusing). Please add a TODO and/or file a bug to clean this up and rename the > method. Done.
	11

	12 #endif // CHROME_BROWSER_METRICS_METRICS_REPORTING_STATE_H_

OLD	NEW