MacViews: AppListDialogContentsView creation takes NativeView parent (instead of NativeWindow)

MacViews: AppListDialogContentsView creation takes NativeView parent (instead of NativeWindow)

views::Widget::InitParams::parent is a NativeView, so these "parent"
types should match. Otherwise it only works on aura where they are both
aura::Windows.

BUG=390755
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283381

[tapted, 2014-07-04 07:17:28]

sasha - let's try out your committer powers ;). PTAL

[sashab, 2014-07-04 07:20:26]

After much thought and discussion, lgtm :)

https://codereview.chromium.org/365243003/diff/1/chrome/browser/ui/views/app_...
File chrome/browser/ui/views/app_list/app_list_dialog_contents_view.cc (right):

https://codereview.chromium.org/365243003/diff/1/chrome/browser/ui/views/app_...
chrome/browser/ui/views/app_list/app_list_dialog_contents_view.cc:90:
gfx::NativeView parent,
Mmm yes I see hrmm hrmm alright. :)

https://codereview.chromium.org/365243003/diff/1/chrome/browser/ui/views/app_...
File chrome/browser/ui/views/app_list/app_list_dialog_contents_view.h (right):

https://codereview.chromium.org/365243003/diff/1/chrome/browser/ui/views/app_...
chrome/browser/ui/views/app_list/app_list_dialog_contents_view.h:30: static
views::Widget* CreateDialogWidget(gfx::NativeView parent,
Hmm hmm yes this looks quite good.

[tapted, 2014-07-04 07:23:25]

https://codereview.chromium.org/365243003/diff/1/chrome/browser/ui/views/app_...
File chrome/browser/ui/views/app_list/app_list_dialog_contents_view.cc (right):

https://codereview.chromium.org/365243003/diff/1/chrome/browser/ui/views/app_...
chrome/browser/ui/views/app_list/app_list_dialog_contents_view.cc:90:
gfx::NativeView parent,
On 2014/07/04 07:20:26, sasha_b wrote:
> Mmm yes I see hrmm hrmm alright. :)

Done.

https://codereview.chromium.org/365243003/diff/1/chrome/browser/ui/views/app_...
File chrome/browser/ui/views/app_list/app_list_dialog_contents_view.h (right):

https://codereview.chromium.org/365243003/diff/1/chrome/browser/ui/views/app_...
chrome/browser/ui/views/app_list/app_list_dialog_contents_view.h:30: static
views::Widget* CreateDialogWidget(gfx::NativeView parent,
On 2014/07/04 07:20:26, sasha_b wrote:
> Hmm hmm yes this looks quite good.

Yeah - decided to do this in this CL rather than defer to a follow-up ;)

[tapted, 2014-07-04 07:34:19]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-07-04 07:34:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tapted@chromium.org/365243003/1

[commit-bot: I haz the power, 2014-07-04 07:34:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-04 07:34:46]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[tapted, 2014-07-08 08:06:44]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-07-08 08:07:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tapted@chromium.org/365243003/1

[commit-bot: I haz the power, 2014-07-08 08:07:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-08 08:07:19]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[tapted, 2014-07-16 06:24:01]

let's see if your committer bit has been flipped now...

[tapted, 2014-07-16 06:24:05]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-07-16 06:25:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tapted@chromium.org/365243003/1

[commit-bot: I haz the power, 2014-07-16 07:14:14]

Change committed as 283381