chrome/browser/ui/views/app_list/app_list_dialog_contents_view.h - Issue 365243003: MacViews: AppListDialogContentsView creation takes NativeView parent (instead of NativeWindow)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/app_list/app_list_dialog_contents_view.h

Issue 365243003: MacViews: AppListDialogContentsView creation takes NativeView parent (instead of NativeWindow) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/views/app_list/app_list_dialog_contents_view.cc » ('j') | chrome/browser/ui/views/app_list/app_list_dialog_contents_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/app_list/app_list_dialog_contents_view.h

diff --git a/chrome/browser/ui/views/app_list/app_list_dialog_contents_view.h b/chrome/browser/ui/views/app_list/app_list_dialog_contents_view.h

index 51654d41db1423a78fa266294c33d97f45460fab..e343a519e971d4688e734f94f7513a546236fe5f 100644

--- a/chrome/browser/ui/views/app_list/app_list_dialog_contents_view.h

+++ b/chrome/browser/ui/views/app_list/app_list_dialog_contents_view.h

@@ -27,7 +27,7 @@ class AppListDialogContentsView : public views::WidgetDelegateView,

// Create a |dialog| window Widget with the specified |parent|. The dialog

// will be resized to fill the body of the app list.

- static views::Widget* CreateDialogWidget(gfx::NativeWindow parent,

+ static views::Widget* CreateDialogWidget(gfx::NativeView parent,

sashab 2014/07/04 07:20:26 Hmm hmm yes this looks quite good.

tapted 2014/07/04 07:23:25 Yeah - decided to do this in this CL rather than d

const gfx::Rect& bounds,

AppListDialogContentsView* dialog);