Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 365223004: Have the form control element directly handle validation message updating. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Have the form control element directly handle validation message updating. Remove the small ValidationMessage class, merging its functionality into its owning form control element. R=tkent@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177527

Patch Set 1 #

Total comments: 3

Patch Set 2 : Move m_hasValidationMessage checks out from validationMessageClient() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -167 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/FormAssociatedElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 2 chunks +5 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 5 chunks +39 lines, -9 lines 0 comments Download
D Source/core/html/forms/ValidationMessage.h View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/core/html/forms/ValidationMessage.cpp View 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sof
Please take a look. As agreed&settled on some time ago, merge in ValidationMessage.
6 years, 5 months ago (2014-07-04 07:33:03 UTC) #1
tkent
https://codereview.chromium.org/365223004/diff/1/Source/core/html/HTMLFormControlElement.cpp File Source/core/html/HTMLFormControlElement.cpp (right): https://codereview.chromium.org/365223004/diff/1/Source/core/html/HTMLFormControlElement.cpp#newcode444 Source/core/html/HTMLFormControlElement.cpp:444: if (!m_hasValidationMessage) Checking this in validationMessageClient() is weird. This ...
6 years, 5 months ago (2014-07-04 07:43:30 UTC) #2
sof
https://codereview.chromium.org/365223004/diff/1/Source/core/html/HTMLFormControlElement.cpp File Source/core/html/HTMLFormControlElement.cpp (right): https://codereview.chromium.org/365223004/diff/1/Source/core/html/HTMLFormControlElement.cpp#newcode444 Source/core/html/HTMLFormControlElement.cpp:444: if (!m_hasValidationMessage) On 2014/07/04 07:43:30, tkent wrote: > Checking ...
6 years, 5 months ago (2014-07-04 07:45:34 UTC) #3
sof
https://codereview.chromium.org/365223004/diff/1/Source/core/html/HTMLFormControlElement.cpp File Source/core/html/HTMLFormControlElement.cpp (right): https://codereview.chromium.org/365223004/diff/1/Source/core/html/HTMLFormControlElement.cpp#newcode444 Source/core/html/HTMLFormControlElement.cpp:444: if (!m_hasValidationMessage) On 2014/07/04 07:45:33, sof wrote: > On ...
6 years, 5 months ago (2014-07-04 07:50:19 UTC) #4
tkent
lgtm
6 years, 5 months ago (2014-07-04 07:53:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/365223004/20001
6 years, 5 months ago (2014-07-04 07:53:39 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-04 08:59:15 UTC) #7
Message was sent while issue was closed. 
Change committed as 177527

Powered by Google App Engine
This is Rietveld 408576698