Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: Source/core/html/HTMLFormControlElement.h

Issue 365223004: Have the form control element directly handle validation message updating. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Move m_hasValidationMessage checks out from validationMessageClient() Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/FormAssociatedElement.h ('k') | Source/core/html/HTMLFormControlElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFormControlElement.h
diff --git a/Source/core/html/HTMLFormControlElement.h b/Source/core/html/HTMLFormControlElement.h
index eae67074b0bf0cc1d009c498cfd859947ca1ebc6..85e8a8c74cbf80b2ab77f1ddb0c51d700d922ed2 100644
--- a/Source/core/html/HTMLFormControlElement.h
+++ b/Source/core/html/HTMLFormControlElement.h
@@ -33,7 +33,7 @@ class FormDataList;
class HTMLFieldSetElement;
class HTMLFormElement;
class HTMLLegendElement;
-class ValidationMessage;
+class ValidationMessageClient;
class ValidityState;
// HTMLFormControlElement is the default implementation of FormAssociatedElement,
@@ -157,11 +157,14 @@ private:
virtual bool isValidFormControlElement() OVERRIDE FINAL;
void updateAncestorDisabledState() const;
- OwnPtr<ValidationMessage> m_validationMessage;
+ bool isValidationMessageVisible() const;
+ ValidationMessageClient* validationMessageClient() const;
+
bool m_disabled : 1;
bool m_isAutofilled : 1;
bool m_isReadOnly : 1;
bool m_isRequired : 1;
+ bool m_hasValidationMessage : 1;
enum AncestorDisabledState { AncestorDisabledStateUnknown, AncestorDisabledStateEnabled, AncestorDisabledStateDisabled };
mutable AncestorDisabledState m_ancestorDisabledState;
« no previous file with comments | « Source/core/html/FormAssociatedElement.h ('k') | Source/core/html/HTMLFormControlElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698