Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 365153002: Remove a bunch of Isolate::UncheckedCurrent calls (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
Sven Panne
CC:
Paweł Hajdan Jr., v8-dev
Project:
v8
Visibility:
Public.

Description

Remove a bunch of Isolate::UncheckedCurrent calls The callbacks are per isolate, so we shouldn't get the isolate implicitly from TLS. Also, we shouldn't allow calls to these methods prior to initializing the respective isolate (and silently ignore them). Esp. add a per-isolate API to set the stats counter callbacks and make it possible to set the stats counter callback after the isolate was touched. Embedders should use e.g. isolate->SetCounterFunction(callback) instead of v8::V8::SetCounterFunction(callback). BUG=none R=svenpanne@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=22223

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -25 lines) Patch
M include/v8.h View 3 chunks +19 lines, -0 lines 3 comments Download
M src/api.cc View 3 chunks +27 lines, -3 lines 0 comments Download
M src/counters.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/counters.cc View 1 chunk +32 lines, -0 lines 0 comments Download
M src/d8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/d8.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M test/cctest/test-api.cc View 1 6 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-03 15:39:17 UTC) #1
Sven Panne
LGTM with nits. Furthermore, a short explanation *why* this is beneficial should be in the ...
6 years, 5 months ago (2014-07-07 06:50:18 UTC) #2
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-07 07:20:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22223 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698