Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: include/v8.h

Issue 365153002: Remove a bunch of Isolate::UncheckedCurrent calls (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: updates Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index f0cde0f997c3e188d3f2e05138c7cda5942ae5c6..3b074ea7f8b930e9166d759ca6ed57d1015b410b 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -4430,6 +4430,21 @@ class V8_EXPORT Isolate {
*/
void SetUseCounterCallback(UseCounterCallback callback);
+ /**
+ * Enables the host application to provide a mechanism for recording
+ * statistics counters.
+ */
+ void SetCounterFunction(CounterLookupCallback);
+
+ /**
+ * Enables the host application to provide a mechanism for recording
+ * histograms. The CreateHistogram function returns a
+ * histogram which will later be passed to the AddHistogramSample
+ * function.
+ */
+ void SetCreateHistogramFunction(CreateHistogramCallback);
+ void SetAddHistogramSampleFunction(AddHistogramSampleCallback);
+
private:
template<class K, class V, class Traits> friend class PersistentValueMap;
@@ -4744,6 +4759,8 @@ class V8_EXPORT V8 {
/**
* Enables the host application to provide a mechanism for recording
* statistics counters.
+ *
+ * Deprecated, will be removed.
Sven Panne 2014/07/07 06:50:18 I think that Deprecated, use Isolate::SetCount
*/
static void SetCounterFunction(CounterLookupCallback);
@@ -4752,6 +4769,8 @@ class V8_EXPORT V8 {
* histograms. The CreateHistogram function returns a
* histogram which will later be passed to the AddHistogramSample
* function.
+ *
+ * Deprecated, will be removed.
Sven Panne 2014/07/07 06:50:18 Same here.
*/
static void SetCreateHistogramFunction(CreateHistogramCallback);
static void SetAddHistogramSampleFunction(AddHistogramSampleCallback);
Sven Panne 2014/07/07 06:50:18 Missing deprecation comment.
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698