Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: components/breakpad/app/breakpad_client.h

Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits:grt Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/google_update_settings.cc ('k') | components/breakpad/app/breakpad_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/breakpad/app/breakpad_client.h
diff --git a/components/breakpad/app/breakpad_client.h b/components/breakpad/app/breakpad_client.h
index fb3b20506bee0eca31a552d3e43a9b6fda7bbbf2..7ade184c230e5aacc093a8224717a572368f3bec 100644
--- a/components/breakpad/app/breakpad_client.h
+++ b/components/breakpad/app/breakpad_client.h
@@ -46,7 +46,9 @@ class BreakpadClient {
// Sets the Breakpad client ID, which is a unique identifier for the client
// that is sending crash reports. After it is set, it should not be changed.
- virtual void SetClientID(const std::string& client_id);
+ // |client_guid| may either be a full GUID or a GUID that was already stripped
+ // from its dashes.
+ virtual void SetBreakpadClientIdFromGUID(const std::string& client_guid);
#if defined(OS_WIN)
// Returns true if an alternative location to store the minidump files was
« no previous file with comments | « chrome/installer/util/google_update_settings.cc ('k') | components/breakpad/app/breakpad_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698