Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: components/breakpad/app/breakpad_client.h

Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits:grt Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_BREAKPAD_APP_BREAKPAD_CLIENT_H_ 5 #ifndef COMPONENTS_BREAKPAD_APP_BREAKPAD_CLIENT_H_
6 #define COMPONENTS_BREAKPAD_APP_BREAKPAD_CLIENT_H_ 6 #define COMPONENTS_BREAKPAD_APP_BREAKPAD_CLIENT_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 28 matching lines...) Expand all
39 #endif 39 #endif
40 40
41 // Interface that the embedder implements. 41 // Interface that the embedder implements.
42 class BreakpadClient { 42 class BreakpadClient {
43 public: 43 public:
44 BreakpadClient(); 44 BreakpadClient();
45 virtual ~BreakpadClient(); 45 virtual ~BreakpadClient();
46 46
47 // Sets the Breakpad client ID, which is a unique identifier for the client 47 // Sets the Breakpad client ID, which is a unique identifier for the client
48 // that is sending crash reports. After it is set, it should not be changed. 48 // that is sending crash reports. After it is set, it should not be changed.
49 virtual void SetClientID(const std::string& client_id); 49 // |client_guid| may either be a full GUID or a GUID that was already stripped
50 // from its dashes.
51 virtual void SetBreakpadClientIdFromGUID(const std::string& client_guid);
50 52
51 #if defined(OS_WIN) 53 #if defined(OS_WIN)
52 // Returns true if an alternative location to store the minidump files was 54 // Returns true if an alternative location to store the minidump files was
53 // specified. Returns true if |crash_dir| was set. 55 // specified. Returns true if |crash_dir| was set.
54 virtual bool GetAlternativeCrashDumpLocation(base::FilePath* crash_dir); 56 virtual bool GetAlternativeCrashDumpLocation(base::FilePath* crash_dir);
55 57
56 // Returns a textual description of the product type and version to include 58 // Returns a textual description of the product type and version to include
57 // in the crash report. 59 // in the crash report.
58 virtual void GetProductNameAndVersion(const base::FilePath& exe_path, 60 virtual void GetProductNameAndVersion(const base::FilePath& exe_path,
59 base::string16* product_name, 61 base::string16* product_name,
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 virtual void InstallAdditionalFilters(BreakpadRef breakpad); 134 virtual void InstallAdditionalFilters(BreakpadRef breakpad);
133 #endif 135 #endif
134 136
135 // Returns true if breakpad should run in the given process type. 137 // Returns true if breakpad should run in the given process type.
136 virtual bool EnableBreakpadForProcess(const std::string& process_type); 138 virtual bool EnableBreakpadForProcess(const std::string& process_type);
137 }; 139 };
138 140
139 } // namespace breakpad 141 } // namespace breakpad
140 142
141 #endif // COMPONENTS_BREAKPAD_APP_BREAKPAD_CLIENT_H_ 143 #endif // COMPONENTS_BREAKPAD_APP_BREAKPAD_CLIENT_H_
OLDNEW
« no previous file with comments | « chrome/installer/util/google_update_settings.cc ('k') | components/breakpad/app/breakpad_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698