chrome/app/chrome_breakpad_client.h - Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_breakpad_client.h

Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nits:grt Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chrome_breakpad_client.h

diff --git a/chrome/app/chrome_breakpad_client.h b/chrome/app/chrome_breakpad_client.h

index 489e8fe512b0bd480dcb811f5bfe4e9443be6670..7b750bd201461567df49a75408dc616c73ab195f 100644

--- a/chrome/app/chrome_breakpad_client.h

+++ b/chrome/app/chrome_breakpad_client.h

@@ -17,7 +17,8 @@ class ChromeBreakpadClient : public breakpad::BreakpadClient {

virtual ~ChromeBreakpadClient();

// breakpad::BreakpadClient implementation.

- virtual void SetClientID(const std::string& client_id) OVERRIDE;

+ virtual void SetBreakpadClientIdFromGUID(

+ const std::string& client_guid) OVERRIDE;

#if defined(OS_WIN)

virtual bool GetAlternativeCrashDumpLocation(base::FilePath* crash_dir)

OVERRIDE;

« no previous file with comments | « no previous file | chrome/app/chrome_breakpad_client.cc » ('j') | no next file with comments »