Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Side by Side Diff: chrome/app/chrome_breakpad_client.h

Issue 365133005: Refactor SetClientID such that metrics rather than crash backs up the client id in Google Update set (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits:grt Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/app/chrome_breakpad_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_APP_CHROME_BREAKPAD_CLIENT_H_ 5 #ifndef CHROME_APP_CHROME_BREAKPAD_CLIENT_H_
6 #define CHROME_APP_CHROME_BREAKPAD_CLIENT_H_ 6 #define CHROME_APP_CHROME_BREAKPAD_CLIENT_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "components/breakpad/app/breakpad_client.h" 10 #include "components/breakpad/app/breakpad_client.h"
11 11
12 namespace chrome { 12 namespace chrome {
13 13
14 class ChromeBreakpadClient : public breakpad::BreakpadClient { 14 class ChromeBreakpadClient : public breakpad::BreakpadClient {
15 public: 15 public:
16 ChromeBreakpadClient(); 16 ChromeBreakpadClient();
17 virtual ~ChromeBreakpadClient(); 17 virtual ~ChromeBreakpadClient();
18 18
19 // breakpad::BreakpadClient implementation. 19 // breakpad::BreakpadClient implementation.
20 virtual void SetClientID(const std::string& client_id) OVERRIDE; 20 virtual void SetBreakpadClientIdFromGUID(
21 const std::string& client_guid) OVERRIDE;
21 #if defined(OS_WIN) 22 #if defined(OS_WIN)
22 virtual bool GetAlternativeCrashDumpLocation(base::FilePath* crash_dir) 23 virtual bool GetAlternativeCrashDumpLocation(base::FilePath* crash_dir)
23 OVERRIDE; 24 OVERRIDE;
24 virtual void GetProductNameAndVersion(const base::FilePath& exe_path, 25 virtual void GetProductNameAndVersion(const base::FilePath& exe_path,
25 base::string16* product_name, 26 base::string16* product_name,
26 base::string16* version, 27 base::string16* version,
27 base::string16* special_build, 28 base::string16* special_build,
28 base::string16* channel_name) OVERRIDE; 29 base::string16* channel_name) OVERRIDE;
29 virtual bool ShouldShowRestartDialog(base::string16* title, 30 virtual bool ShouldShowRestartDialog(base::string16* title,
30 base::string16* message, 31 base::string16* message,
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 virtual bool EnableBreakpadForProcess( 68 virtual bool EnableBreakpadForProcess(
68 const std::string& process_type) OVERRIDE; 69 const std::string& process_type) OVERRIDE;
69 70
70 private: 71 private:
71 DISALLOW_COPY_AND_ASSIGN(ChromeBreakpadClient); 72 DISALLOW_COPY_AND_ASSIGN(ChromeBreakpadClient);
72 }; 73 };
73 74
74 } // namespace chrome 75 } // namespace chrome
75 76
76 #endif // CHROME_APP_CHROME_BREAKPAD_CLIENT_H_ 77 #endif // CHROME_APP_CHROME_BREAKPAD_CLIENT_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/app/chrome_breakpad_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698