net/socket/ssl_client_socket_pool.h - Issue 364943002: Makes waiting SSLConnectJobs use the message loops to resume their connection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_pool.h

Issue 364943002: Makes waiting SSLConnectJobs use the message loops to resume their connection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/socket/ssl_client_socket_openssl.cc ('K') | « net/socket/ssl_client_socket_openssl.cc ('k') | net/socket/ssl_client_socket_pool.cc » ('j') | net/socket/ssl_client_socket_pool.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/socket/ssl_client_socket_pool.h

diff --git a/net/socket/ssl_client_socket_pool.h b/net/socket/ssl_client_socket_pool.h

index 12680a843d8c9486caae87afc62862b55926038f..460501e07b6d759215ae90b738cecbe183818f31 100644

--- a/net/socket/ssl_client_socket_pool.h

+++ b/net/socket/ssl_client_socket_pool.h

@@ -171,7 +171,7 @@ class NET_EXPORT SSLConnectJobMessenger {

for (std::vector<base::Closure>::iterator it = callbacks_.begin();

it != callbacks_.end();

it++)

- it->Run();

+ base::MessageLoopForIO::current()->PostTask(FROM_HERE, *it);

wtc 2014/07/08 17:37:03 1. IMPORTANT: this will make cancelling the callba

mshelley 2014/07/09 21:53:06 The callbacks that are being posted here are bound

}

SSLClientSocket* GetFirstSocket() {

« net/socket/ssl_client_socket_openssl.cc ('K') | « net/socket/ssl_client_socket_openssl.cc ('k') | net/socket/ssl_client_socket_pool.cc » ('j') | net/socket/ssl_client_socket_pool.cc » ('J')