Makes waiting SSLConnectJobs use the message loops to resume their connection.

net/socket/ssl_client_socket_pool.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_SSL_CLIENT_SOCKET_POOL_H_
 #define NET_SOCKET_SSL_CLIENT_SOCKET_POOL_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 153 matching lines @@
     void Clear() {
       pending_sockets_.clear();
       callbacks_.clear();
     }
 
     // Tells all pending connections to resume.
     void RunAllJobs() {
       for (std::vector<base::Closure>::iterator it = callbacks_.begin();
            it != callbacks_.end();
            it++)
-        it->Run();
+       base::MessageLoopForIO::current()->PostTask(FROM_HERE, *it);

[wtc, 2014/07/08 17:37:03]

1. IMPORTANT: this will make cancelling the callback of a deleted
SSLClientSocket more difficult. Please make sure that is handled properly, for
example, by the use of WeakPtrs.

2. Nit: the indentation is off by one. Can "git cl format" fix this?

[mshelley, 2014/07/09 21:53:06]

The callbacks that are being posted here are bound to SSLConnectJob WeakPtrs, so
I believe they should be handled correctly should the job be cancelled. My
understanding was that the socket should always outlive the job; if that is the
case, then the callback for a deleted socket simply wouldn't be run, which I
believe is what we would want in this case.

     }
 
     SSLClientSocket* GetFirstSocket() {
       DCHECK(!pending_sockets_.empty());
       return pending_sockets_[0];
     }
 
     base::Closure GetFirstCallback() {
       DCHECK(!callbacks_.empty());
       return callbacks_[0];
@@ skipping 247 matching lines @@
   HttpProxyClientSocketPool* const http_proxy_pool_;
   PoolBase base_;
   const scoped_refptr<SSLConfigService> ssl_config_service_;
 
   DISALLOW_COPY_AND_ASSIGN(SSLClientSocketPool);
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_SSL_CLIENT_SOCKET_POOL_H_