net/socket/ssl_client_socket_openssl.cc - Issue 364943002: Makes waiting SSLConnectJobs use the message loops to resume their connection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_openssl.cc

Issue 364943002: Makes waiting SSLConnectJobs use the message loops to resume their connection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed use after free bug & other cl comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/ssl_client_socket_openssl.cc

diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc

index d6899f8a5e1e64b4c5582a659942028217a4b06c..8401b1df7adefd53806019adcbf608f05b7c838f 100644

--- a/net/socket/ssl_client_socket_openssl.cc

+++ b/net/socket/ssl_client_socket_openssl.cc

@@ -16,6 +16,7 @@

#include "base/memory/singleton.h"

#include "base/metrics/histogram.h"

#include "base/synchronization/lock.h"

+#include "base/thread_task_runner_handle.h"

mmenke 2014/07/22 18:06:32 nit: I don't believe this is needed here.

mshelley 2014/07/23 22:09:07 Done.

#include "crypto/ec_private_key.h"

#include "crypto/openssl_util.h"

#include "net/base/net_errors.h"

« net/socket/ssl_client_socket.h ('K') | « net/socket/ssl_client_socket.h ('k') | net/socket/ssl_client_socket_pool.h » ('j') | net/socket/ssl_client_socket_pool.h » ('J')