net/socket/ssl_client_socket.h - Issue 364943002: Makes waiting SSLConnectJobs use the message loops to resume their connection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket.h

Issue 364943002: Makes waiting SSLConnectJobs use the message loops to resume their connection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed use after free bug & other cl comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/ssl_client_socket.h

diff --git a/net/socket/ssl_client_socket.h b/net/socket/ssl_client_socket.h

index fb1f2f215bcd380a8cd3a25b63e779c46bb299c1..bcddfb5eeea6575256ff1585545398c8b4e71225 100644

--- a/net/socket/ssl_client_socket.h

+++ b/net/socket/ssl_client_socket.h

@@ -104,6 +104,9 @@ class NET_EXPORT SSLClientSocket : public SSLSocket {

// Sets the callback to be used if the socket's ssl handshake should fail.

virtual void SetHandshakeFailureCallback(const base::Closure& callback) = 0;

+ // In the case of a failed connection, run the appropriate callback.

+ virtual void OnSocketFailure() = 0;

mmenke 2014/07/22 18:06:32 Don't believe this belongs in this CL.

mshelley 2014/07/23 22:09:07 I think this is an artifact from a poorly executed

// Gets the SSL CertificateRequest info of the socket after Connect failed

// with ERR_SSL_CLIENT_AUTH_CERT_NEEDED.

virtual void GetSSLCertRequestInfo(

« no previous file with comments | « no previous file | net/socket/ssl_client_socket_openssl.cc » ('j') | net/socket/ssl_client_socket_openssl.cc » ('J')