Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: net/socket/ssl_client_socket.h

Issue 364943002: Makes waiting SSLConnectJobs use the message loops to resume their connection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved documentation and made some methods private. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_openssl.h » ('j') | net/socket/ssl_client_socket_openssl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket.h
diff --git a/net/socket/ssl_client_socket.h b/net/socket/ssl_client_socket.h
index 64e3dc74e4e4ce2c50dc95896c2a2876b696f6d3..e52e11e307499b5be9097a30c9aa583d79d3943a 100644
--- a/net/socket/ssl_client_socket.h
+++ b/net/socket/ssl_client_socket.h
@@ -99,6 +99,9 @@ class NET_EXPORT SSLClientSocket : public SSLSocket {
virtual void WatchSessionForCompletion(const base::Closure& callback) = 0;
// Sets the callback to be used if the socket's connection should fail.
+ //
+ // This callback should be run regardless of whether or not this socket
Ryan Sleevi 2014/07/11 01:25:59 s/should be/will be/ Reworded though: // NOTE: T
mshelley 2014/07/14 20:30:06 Done.
+ // will still be valid at its runtime.
virtual void SetSocketFailureCallback(const base::Closure& callback) = 0;
// Marks this socket as the leading connection.
« no previous file with comments | « no previous file | net/socket/ssl_client_socket_openssl.h » ('j') | net/socket/ssl_client_socket_openssl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698