net/socket/ssl_client_socket_openssl.h - Issue 364943002: Makes waiting SSLConnectJobs use the message loops to resume their connection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_openssl.h

Issue 364943002: Makes waiting SSLConnectJobs use the message loops to resume their connection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved documentation and made some methods private. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/ssl_client_socket_openssl.h

diff --git a/net/socket/ssl_client_socket_openssl.h b/net/socket/ssl_client_socket_openssl.h

index f18eec5874eb50422b0dd28eec163db85e99eb68..f53f017e9ae280e6eb2b3437d1a170337b35d18f 100644

--- a/net/socket/ssl_client_socket_openssl.h

+++ b/net/socket/ssl_client_socket_openssl.h

@@ -222,6 +222,8 @@ class SSLClientSocketOpenSSL : public SSLClientSocket {

ServerBoundCertService* server_bound_cert_service_;

// Callback that is invoked when the connection encounters an error.

+ // This callback should be run regardless of whether or not this socket

+ // will still be valid at its runtime.

Ryan Sleevi 2014/07/11 01:25:59 drop this comment (225-226)

mshelley 2014/07/14 20:30:06 Done.

base::Closure error_callback_;

// True if there may be pending sockets waiting for this socket to connect.

« net/socket/ssl_client_socket.h ('K') | « net/socket/ssl_client_socket.h ('k') | net/socket/ssl_client_socket_openssl.cc » ('j') | net/socket/ssl_client_socket_openssl.cc » ('J')