Port suitableForGpuRasterization to SkRecord

include/core/SkPicture.h

Index: include/core/SkPicture.h
diff --git a/include/core/SkPicture.h b/include/core/SkPicture.h
index 004f1306215306494846a494944bf23559391b47..ad99384c97f2b5b9baee8a841499b8bc48a5cee7 100644
--- a/include/core/SkPicture.h
+++ b/include/core/SkPicture.h
@@ -305,7 +305,27 @@ private:
 
     SkAutoTDelete<SkRecord>       fRecord;
     SkAutoTUnref<SkBBoxHierarchy> fBBH;
-    bool fRecordWillPlayBackBitmaps; // TODO: const
+
+    struct Analysis {
+        Analysis()

[mtklein, 2014/08/19 21:01:01]

Maybe merge these false and 0s into init()?  Either way seems clear to me.

+            : fWillPlaybackBitmaps(false)
+            , fNumPaintWithPathEffectUses(0)
+            , fNumFastPathDashEffects(0)
+            , fNumAAConcavePaths(0)
+            , fNumAAHairlineConcavePaths(0) { }
+
+        // To get setup to work cleanly, we cast away constness and call init()
+        // instead of trying to set everything during construction.
+        void init(const SkRecord&);
+
+        bool suitableForGpuRasterization(const char** reason, int sampleCount) const;
+
+        bool        fWillPlaybackBitmaps;
+        int         fNumPaintWithPathEffectUses;
+        int         fNumFastPathDashEffects;
+        int         fNumAAConcavePaths;
+        int         fNumAAHairlineConcavePaths;
+    } const                       fAnalysis;

[mtklein, 2014/08/19 21:01:01]

The indented fAnalysis perhaps has lost its meaning so far removed from its
friends?

 };
 
 #endif