Port suitableForGpuRasterization to SkRecord

include/core/SkPicture.h

 
 /*
  * Copyright 2007 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkPicture_DEFINED
@@ skipping 287 matching lines @@
     friend class SkPicturePlayback;            // to get fData & OperationList
     friend class SkPictureReplacementPlayback; // to access OperationList
 
     typedef SkRefCnt INHERITED;
 
     // Takes ownership of the SkRecord, refs the (optional) BBH.
     SkPicture(int width, int height, SkRecord*, SkBBoxHierarchy*);
 
     SkAutoTDelete<SkRecord>       fRecord;
     SkAutoTUnref<SkBBoxHierarchy> fBBH;
-    bool fRecordWillPlayBackBitmaps; // TODO: const
+
+    struct Analysis {
+        Analysis()

[mtklein, 2014/08/19 21:01:01]

Maybe merge these false and 0s into init()?  Either way seems clear to me.

+            : fWillPlaybackBitmaps(false)
+            , fNumPaintWithPathEffectUses(0)
+            , fNumFastPathDashEffects(0)
+            , fNumAAConcavePaths(0)
+            , fNumAAHairlineConcavePaths(0) { }
+
+        // To get setup to work cleanly, we cast away constness and call init()
+        // instead of trying to set everything during construction.
+        void init(const SkRecord&);
+
+        bool suitableForGpuRasterization(const char** reason, int sampleCount) const;
+
+        bool        fWillPlaybackBitmaps;
+        int         fNumPaintWithPathEffectUses;
+        int         fNumFastPathDashEffects;
+        int         fNumAAConcavePaths;
+        int         fNumAAHairlineConcavePaths;
+    } const                       fAnalysis;

[mtklein, 2014/08/19 21:01:01]

The indented fAnalysis perhaps has lost its meaning so far removed from its
friends?

 };
 
 #endif