Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 364793007: Fix rerun barrier for flaky tests. (Closed)

Created:
6 years, 5 months ago by Michael Achenbach
Modified:
6 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix rerun barrier for flaky tests. - The rerun flag doesn't include the first run. - Timeout is an int. The division makes it 0 for small numbers. BUG=374134 LOG=n R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22172

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/testrunner/local/execution.py View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 5 months ago (2014-07-02 15:04:02 UTC) #1
Jakob Kummerow
lgtm
6 years, 5 months ago (2014-07-02 15:09:36 UTC) #2
Michael Achenbach
6 years, 5 months ago (2014-07-02 15:33:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22172 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698