Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tools/testrunner/local/execution.py

Issue 364793007: Fix rerun barrier for flaky tests. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testrunner/local/execution.py
diff --git a/tools/testrunner/local/execution.py b/tools/testrunner/local/execution.py
index 939995cd8f112b917953d25ce4c7800b968e5150..43d11ebe8aad687f50cee76e5f2c3db4036ebefc 100644
--- a/tools/testrunner/local/execution.py
+++ b/tools/testrunner/local/execution.py
@@ -104,9 +104,9 @@ class Runner(object):
return Job(command, dep_command, test.id, timeout, self.context.verbose)
def _MaybeRerun(self, pool, test):
- if test.run <= self.context.rerun_failures_count:
+ if test.run <= self.context.rerun_failures_count + 1:
# Possibly rerun this test if its run count is below the maximum per
- # test.
+ # test. +1 as the flag controls reruns not including the first run.
if test.run == 1:
# Count the overall number of reran tests on the first rerun.
if self.reran_tests < self.context.rerun_failures_max:
@@ -115,7 +115,7 @@ class Runner(object):
# Don't rerun this if the overall number of rerun tests has been
# reached.
return
- if test.run >= 2 and test.duration > self.context.timeout / 20:
+ if test.run >= 2 and test.duration > self.context.timeout / 20.0:
# Rerun slow tests at most once.
return
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698