Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 364703002: Return if a host name in an URLPattern has no non-whitespace characters. (Closed)

Created:
6 years, 5 months ago by robwu
Modified:
6 years, 5 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Return if a host name in an URLPattern has no non-whitespace characters. SplitString trims whitespace, so the |host_components| vector could be empty. BUG=390645 TEST=ExtensionURLPatternTest.ParseInvalid Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280935

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M extensions/common/url_pattern.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/common/url_pattern_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robwu
6 years, 5 months ago (2014-07-01 19:22:09 UTC) #1
Devlin
LGTM
6 years, 5 months ago (2014-07-01 21:50:24 UTC) #2
robwu
The CQ bit was checked by rob@robwu.nl
6 years, 5 months ago (2014-07-01 21:59:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob@robwu.nl/364703002/1
6 years, 5 months ago (2014-07-01 22:00:11 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-01 23:53:20 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-02 01:32:00 UTC) #6
Message was sent while issue was closed.
Change committed as 280935

Powered by Google App Engine
This is Rietveld 408576698