extensions/common/url_pattern_unittest.cc - Issue 364703002: Return if a host name in an URLPattern has no non-whitespace characters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/url_pattern_unittest.cc

Issue 364703002: Return if a host name in an URLPattern has no non-whitespace characters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/url_pattern_unittest.cc

diff --git a/extensions/common/url_pattern_unittest.cc b/extensions/common/url_pattern_unittest.cc

index 3e0c816ac35ec2d82a15a5814ed43241b3002d87..8f353cca480c2893f876bea5367ec8f3976a4192 100644

--- a/extensions/common/url_pattern_unittest.cc

+++ b/extensions/common/url_pattern_unittest.cc

@@ -31,6 +31,7 @@ TEST(ExtensionURLPatternTest, ParseInvalid) {

{ "about://", URLPattern::PARSE_ERROR_WRONG_SCHEME_SEPARATOR },

{ "http://", URLPattern::PARSE_ERROR_EMPTY_HOST },

{ "http:///", URLPattern::PARSE_ERROR_EMPTY_HOST },

+ { "http:// /", URLPattern::PARSE_ERROR_EMPTY_HOST },

{ "http://*foo/bar", URLPattern::PARSE_ERROR_INVALID_HOST_WILDCARD },

{ "http://foo.*.bar/baz", URLPattern::PARSE_ERROR_INVALID_HOST_WILDCARD },

{ "http://fo.*.ba:123/baz", URLPattern::PARSE_ERROR_INVALID_HOST_WILDCARD },

« no previous file with comments | « extensions/common/url_pattern.cc ('k') | no next file » | no next file with comments »