Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 364503002: Revert of node.cloneNode() should clone the value of file upload elements (Closed)

Created:
6 years, 5 months ago by tkent
Modified:
6 years, 5 months ago
Reviewers:
keishi, Inactive, gnana
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, ojan
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of node.cloneNode() should clone the value of file upload elements (https://codereview.chromium.org/267713006/) Reason for revert: Caused a serious regression, crbug.com/388795. Original issue's description: > node.cloneNode() should clone the value of file selected > > when input element of type file with a selected file is cloned, the cloned node should > also have the same file as selected. > HTML specification states: > http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html > "The cloning steps for input elements must propagate the value, dirty value > flag, checkedness, and dirty checkedness flag from the node being cloned to the > copy." > > The value for the input element of type fileupload is the filename. > > Behaviours in major Browser: > Firefox- clones filename > Safari, IE & Opera- do not Clone filename > > BUG=71536 > TEST=fast/forms/file/input-file-element-clone.html > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173626 BUG=71536, 388795 TBR=gnanasekar.s@samsung.com NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -59 lines) Patch
D LayoutTests/fast/forms/file/input-file-element-clone.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/forms/file/input-file-element-clone-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/html/forms/FileInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/FileInputType.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/html/forms/InputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/InputType.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tkent
Created Revert of node.cloneNode() should clone the value of file upload elements
6 years, 5 months ago (2014-06-30 23:39:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/364503002/1
6 years, 5 months ago (2014-06-30 23:39:39 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 23:39:39 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-06-30 23:39:40 UTC) #4
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 5 months ago (2014-06-30 23:40:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/364503002/1
6 years, 5 months ago (2014-06-30 23:41:50 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 23:42:24 UTC) #7
Message was sent while issue was closed.
Change committed as 177256

Powered by Google App Engine
This is Rietveld 408576698