Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 364323002: Embed CSS/JS under Source/web/resources/ as GRD resources (Closed)

Created:
6 years, 5 months ago by Jens Widell
Modified:
6 years, 5 months ago
CC:
abarth-chromium, blink-reviews, Daniel Bratell, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@idl-treatnullas-emptystring
Project:
blink
Visibility:
Public.

Description

Embed CSS/JS under Source/web/resources/ as GRD resources Embed the CSS and JS used for the color chooser and date/time chooser as GRD resources instead of as C++ arrays using make-file-array.py. BUG=312586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177591

Patch Set 1 #

Patch Set 2 : add missing include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -97 lines) Patch
M Source/platform/SharedBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/SharedBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ColorChooserPopupUIController.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
M Source/web/DateTimeChooserImpl.cpp View 1 3 chunks +8 lines, -9 lines 0 comments Download
M Source/web/web.gyp View 1 chunk +0 lines, -80 lines 0 comments Download
M public/blink_resources.grd View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Jens Widell
PTAL This is a bit preliminary; I was mostly curious to know what it'd take ...
6 years, 5 months ago (2014-07-04 13:31:41 UTC) #1
abarth-chromium
LGTM We should teach the GRD system how to compress and minify things. It already ...
6 years, 5 months ago (2014-07-04 15:33:59 UTC) #2
haraken
This is a nice change! We can use this for private script JS files.
6 years, 5 months ago (2014-07-05 02:05:05 UTC) #3
Daniel Bratell
lgtm as well. To "undo" the size regression we would want something like https://codereview.chromium.org/375523002 (an ...
6 years, 5 months ago (2014-07-07 06:34:24 UTC) #4
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-07-07 14:47:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/364323002/1
6 years, 5 months ago (2014-07-07 14:47:34 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-07 15:36:23 UTC) #7
Jens Widell
The CQ bit was unchecked by jl@opera.com
6 years, 5 months ago (2014-07-07 15:40:39 UTC) #8
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-07-07 15:44:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/364323002/40001
6 years, 5 months ago (2014-07-07 15:45:15 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-07 16:43:36 UTC) #11
Message was sent while issue was closed.
Change committed as 177591

Powered by Google App Engine
This is Rietveld 408576698