Issue 375523002: Experimenting with rjsmin in grit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 375523002: Experimenting with rjsmin in grit.

Created:
6 years, 5 months ago by Daniel Bratell

Modified:
5 years, 3 months ago

Reviewers:
abarth-chromium

CC:
grit-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master

Visibility:
Public.

More Reviews

Description

Experimenting with rjsmin in grit. BUG=367784

Patch Set 1 #

Patch Set 2 : Cleaned up and moved rjsmin. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+311 lines, -0 lines)			Patch
	M	grit/format/data_pack.py	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
	A	grit/format/rjsmin.py	View	1	1 chunk	+295 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

I don't know this code very well, but you might want to look at https://code.google.com/p/chromium/codesearch#chromium/src/tools/grit/grit/format/html_inline.py. ...

6 years, 5 months ago (2014-07-07 16:18:44 UTC) #1

Daniel Bratell

Seems rjsmin will no longer be used in Blink so we can just move it ...

6 years, 5 months ago (2014-07-08 22:31:45 UTC) #2

newt (away)

How does this fit in with https://code.google.com/p/chromium/issues/detail?id=78368 which is also working on minifying JavaScript?

6 years, 5 months ago (2014-07-08 22:46:28 UTC) #3

Daniel Bratell

6 years, 5 months ago (2014-07-09 06:19:13 UTC) #4

On 2014/07/08 22:46:28, newt wrote:
> How does this fit in with
> https://code.google.com/p/chromium/issues/detail?id=78368 which is also
working
> on minifying JavaScript?

I'm a big fan of that bug and I have suggested that approach to others, but it's
not easy to integrate a massive Java tool in our build system so I'd not hold
other changes for it. If it works, excellent, and we can remove less good
solutions. If it turns out to take a long time to get working, then we could use
90% solutions like this meanwhile.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages