Issue 364253007: Revert of [screen-orientation] Expose orientation info in OrientationInformation interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 364253007: Revert of [screen-orientation] Expose orientation info in OrientationInformation interface. (Closed)

Created:
6 years, 5 months ago by lushnikov

Modified:
6 years, 5 months ago

Reviewers:
abarth-chromium, sof, Inactive, mlamouri (slow - plz ping), Michael van Ouwerkerk

CC:
blink-reviews, oilpan-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of [screen-orientation] Expose orientation info in OrientationInformation interface. (https://codereview.chromium.org/366853008/) Reason for revert: Speculative revert: seems like a cause of Linux_ASAN memory leak after blink roll. http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASan%20LSan%20Tests%20%283%29&number=4884 Original issue's description: > [screen-orientation] Expose orientation info in OrientationInformation interface. > > BUG=162827 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177486 TBR=abarth@chromium.org,ch.dumez@samsung.com,mvanouwerkerk@chromium.org,sigbjornf@opera.com,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true BUG=162827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177542

Patch Set 1 #

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -273 lines)			Patch
M	LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	LayoutTests/screen_orientation/lockOrientation-bad-argument.html	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	LayoutTests/screen_orientation/lockOrientation-bad-argument-expected.txt	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/screen_orientation/lockOrientation-bad-array-argument-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/screen_orientation/orientation-attribute.html	View	1 chunk	+4 lines, -42 lines	0 comments	Download
A	LayoutTests/screen_orientation/orientation-attribute-expected.txt	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	LayoutTests/screen_orientation/orientationchange-event.html	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/screen_orientation/orientationchange-event-subframe.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/screen_orientation/page-visibility.html	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/screen_orientation/resources/iframe-listen-orientation-change.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/webexposed/global-constructors-listing-expected.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/frame/LocalFrame.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/frame/LocalFrame.cpp	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	Source/modules/modules.gypi	View	2 chunks	+0 lines, -3 lines	0 comments	Download
D	Source/modules/screen_orientation/OrientationInformation.h	View	1 chunk	+0 lines, -39 lines	0 comments	Download
D	Source/modules/screen_orientation/OrientationInformation.cpp	View	1 chunk	+0 lines, -45 lines	0 comments	Download
D	Source/modules/screen_orientation/OrientationInformation.idl	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	Source/modules/screen_orientation/ScreenOrientation.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/modules/screen_orientation/ScreenOrientation.cpp	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	Source/modules/screen_orientation/ScreenOrientation.idl	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	Source/modules/screen_orientation/ScreenOrientationController.h	View	3 chunks	+4 lines, -10 lines	0 comments	Download
M	Source/modules/screen_orientation/ScreenOrientationController.cpp	View	4 chunks	+29 lines, -68 lines	0 comments	Download
M	Source/web/WebLocalFrameImpl.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lushnikov

Created Revert of [screen-orientation] Expose orientation info in OrientationInformation interface.

6 years, 5 months ago (2014-07-04 15:50:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/364253007/1

6 years, 5 months ago (2014-07-04 15:51:08 UTC) #2

Message was sent while issue was closed.

Change committed as 177542

Expand Messages | Collapse Messages