Issue 364213005: Revert 281282 "Revert 281133 "chrome.hid: enrich model with repo..."

Issue 364213005: Revert 281282 "Revert 281133 "chrome.hid: enrich model with repo..." (Closed)

Created:
6 years, 5 months ago by csharp

Modified:
6 years, 5 months ago

Reviewers:
csharp

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 281282 "Revert 281133 "chrome.hid: enrich model with repo..." Tests still failed, undoing revert. > Revert 281133 "chrome.hid: enrich model with report IDs" > > Speculative revert to try and fix Win browser tests. > > > chrome.hid: enrich model with report IDs > > > > - add report IDs and max report size > > - don't expose sensitive usages > > > > BUG=364423 > > R=rockot@chromium.org > > TESTS=run device_unittests (HidReportDescriptorTest) > > > > Review URL: https://codereview.chromium.org/317783010 > > TBR=jracle@logitech.com > > Review URL: https://codereview.chromium.org/369923002 TBR=csharp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281300

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1197 lines, -1092 lines)			Patch
M	trunk/src/chrome/browser/extensions/api/hid/hid_device_manager.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/hid/hid_device_manager.cc	View	2 chunks	+37 lines, -58 lines	0 comments	Download
M	trunk/src/chrome/common/extensions/api/hid.idl	View	2 chunks	+15 lines, -9 lines	0 comments	Download
M	trunk/src/device/hid/hid.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	trunk/src/device/hid/hid_collection_info.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/device/hid/hid_collection_info.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection.h	View	2 chunks	+48 lines, -13 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection.cc	View	2 chunks	+175 lines, -5 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection_linux.h	View	3 chunks	+19 lines, -17 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection_linux.cc	View	6 chunks	+69 lines, -55 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection_mac.h	View	3 chunks	+18 lines, -21 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection_mac.cc	View	4 chunks	+58 lines, -65 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection_win.h	View	2 chunks	+23 lines, -22 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection_win.cc	View	7 chunks	+44 lines, -88 lines	0 comments	Download
M	trunk/src/device/hid/hid_device_info.h	View	2 chunks	+9 lines, -10 lines	0 comments	Download
M	trunk/src/device/hid/hid_device_info.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
MM	trunk/src/device/hid/hid_report_descriptor.h	View	2 chunks	+7 lines, -4 lines	0 comments	Download
MM	trunk/src/device/hid/hid_report_descriptor.cc	View	2 chunks	+136 lines, -24 lines	0 comments	Download
MM	trunk/src/device/hid/hid_report_descriptor_item.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
MM	trunk/src/device/hid/hid_report_descriptor_unittest.cc	View	2 chunks	+364 lines, -548 lines	0 comments	Download
M	trunk/src/device/hid/hid_service_linux.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	trunk/src/device/hid/hid_service_mac.cc	View	3 chunks	+93 lines, -26 lines	0 comments	Download
M	trunk/src/device/hid/hid_service_win.cc	View	1 chunk	+40 lines, -28 lines	0 comments	Download
M	trunk/src/device/hid/hid_usage_and_page.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
MM	trunk/src/device/hid/hid_usage_and_page.cc	View	1 chunk	+25 lines, -2 lines	0 comments	Download
D	trunk/src/device/hid/hid_utils_mac.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	trunk/src/device/hid/hid_utils_mac.cc	View	1 chunk	+0 lines, -45 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r281300.

Expand Messages | Collapse Messages