Issue 369923002: Revert 281133 "chrome.hid: enrich model with report IDs"

Issue 369923002: Revert 281133 "chrome.hid: enrich model with report IDs" (Closed)

Created:
6 years, 5 months ago by csharp

Modified:
6 years, 5 months ago

Reviewers:
jracle (use Gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 281133 "chrome.hid: enrich model with report IDs" Speculative revert to try and fix Win browser tests. > chrome.hid: enrich model with report IDs > > - add report IDs and max report size > - don't expose sensitive usages > > BUG=364423 > R=rockot@chromium.org > TESTS=run device_unittests (HidReportDescriptorTest) > > Review URL: https://codereview.chromium.org/317783010 TBR=jracle@logitech.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281282

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1017 lines, -1243 lines)			Patch
M	trunk/src/chrome/browser/extensions/api/hid/hid_device_manager.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/hid/hid_device_manager.cc	View	2 chunks	+58 lines, -37 lines	0 comments	Download
M	trunk/src/chrome/common/extensions/api/hid.idl	View	2 chunks	+9 lines, -15 lines	0 comments	Download
M	trunk/src/device/hid/hid.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	trunk/src/device/hid/hid_collection_info.h	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	trunk/src/device/hid/hid_collection_info.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection.h	View	2 chunks	+13 lines, -48 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection.cc	View	2 chunks	+5 lines, -175 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection_linux.h	View	3 chunks	+17 lines, -19 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection_linux.cc	View	6 chunks	+55 lines, -69 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection_mac.h	View	3 chunks	+21 lines, -18 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection_mac.cc	View	4 chunks	+65 lines, -58 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection_win.h	View	2 chunks	+22 lines, -23 lines	0 comments	Download
M	trunk/src/device/hid/hid_connection_win.cc	View	7 chunks	+88 lines, -44 lines	0 comments	Download
M	trunk/src/device/hid/hid_device_info.h	View	2 chunks	+10 lines, -9 lines	0 comments	Download
M	trunk/src/device/hid/hid_device_info.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
MM	trunk/src/device/hid/hid_report_descriptor.h	View	2 chunks	+4 lines, -7 lines	0 comments	Download
MM	trunk/src/device/hid/hid_report_descriptor.cc	View	2 chunks	+24 lines, -136 lines	0 comments	Download
MM	trunk/src/device/hid/hid_report_descriptor_item.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
MM	trunk/src/device/hid/hid_report_descriptor_unittest.cc	View	2 chunks	+548 lines, -364 lines	0 comments	Download
M	trunk/src/device/hid/hid_service_linux.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	trunk/src/device/hid/hid_service_mac.cc	View	3 chunks	+26 lines, -93 lines	0 comments	Download
M	trunk/src/device/hid/hid_service_win.cc	View	1 chunk	+28 lines, -40 lines	0 comments	Download
M	trunk/src/device/hid/hid_usage_and_page.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
MM	trunk/src/device/hid/hid_usage_and_page.cc	View	1 chunk	+2 lines, -25 lines	0 comments	Download
A +	trunk/src/device/hid/hid_utils_mac.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/device/hid/hid_utils_mac.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

csharp

6 years, 5 months ago (2014-07-03 17:14:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r281282 (tree was closed).

Expand Messages | Collapse Messages