Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3400)

Unified Diff: cc/layers/picture_layer_impl.cc

Issue 364063005: Histogram to track missing and incomplete tiles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/picture_layer_impl.cc
diff --git a/cc/layers/picture_layer_impl.cc b/cc/layers/picture_layer_impl.cc
index 248391c7a3433af2353e3609bc5a154f7570fbcd..17f73fbc95dd7ff2b28889a1ba200cfad69960a3 100644
--- a/cc/layers/picture_layer_impl.cc
+++ b/cc/layers/picture_layer_impl.cc
@@ -238,7 +238,6 @@ void PictureLayerImpl::AppendQuads(
color = DebugColors::MissingTileBorderColor();
width = DebugColors::MissingTileBorderWidth(layer_tree_impl());
}
-
scoped_ptr<DebugBorderDrawQuad> debug_border_quad =
DebugBorderDrawQuad::Create();
gfx::Rect geometry_rect = iter.geometry_rect();
@@ -281,8 +280,9 @@ void PictureLayerImpl::AppendQuads(
gfx::Rect opaque_rect = iter->opaque_rect();
opaque_rect.Intersect(geometry_rect);
- if (iter->contents_scale() != ideal_contents_scale_)
- append_quads_data->had_incomplete_tile = true;
+ if (iter->contents_scale() != ideal_contents_scale_) {
danakj 2014/07/07 20:06:27 nit: don't need to add {}
weiliangc 2014/07/07 22:01:21 Done.
+ append_quads_data->num_incomplete_tiles++;
+ }
scoped_ptr<TileDrawQuad> quad = TileDrawQuad::Create();
quad->SetNew(shared_quad_state,
@@ -358,7 +358,7 @@ void PictureLayerImpl::AppendQuads(
}
append_quads_data->num_missing_tiles++;
- append_quads_data->had_incomplete_tile = true;
+ append_quads_data->num_incomplete_tiles++;
danakj 2014/07/07 20:06:28 this means we're double counting missing tiles as
weiliangc 2014/07/07 22:01:21 Done.
append_quads_data->approximated_visible_content_area +=
visible_geometry_rect.width() * visible_geometry_rect.height();
++missing_tile_count;

Powered by Google App Engine
This is Rietveld 408576698