Histogram to track missing and incomplete tiles

cc/trees/layer_tree_host_impl.cc

Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index 1c62fb1f67eb2049582c01b2c5a92c18eb88a53a..91486bbae3f2b2b2267e17b7aca4f10f3500e23f 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -778,6 +778,9 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(
 
   int layers_drawn = 0;
 
+  int num_missing_tiles = 0;
+  int num_incomplete_tiles = 0;
+
   const DrawMode draw_mode = GetDrawMode(output_surface_.get());
 
   LayerIteratorType end =
@@ -856,6 +859,7 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(
         append_quads_data.approximated_visible_content_area);
 
     if (append_quads_data.num_missing_tiles) {
+      num_missing_tiles += append_quads_data.num_missing_tiles;
       bool layer_has_animating_transform =
           it->screen_space_transform_is_animating() ||
           it->draw_transform_is_animating();
@@ -863,7 +867,8 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(
         draw_result = DRAW_ABORTED_CHECKERBOARD_ANIMATIONS;
     }
 
-    if (append_quads_data.had_incomplete_tile) {
+    if (append_quads_data.num_incomplete_tiles > 0) {

[danakj, 2014/07/07 20:06:28]

you can still just do if (append_quads_data.num_incomplete_tiles)

.. tho, i think we should do

if (append_quads_data.num_incomplete_tiles ||
append_quads_data.num_missing_tiles)

as per earlier comment

[weiliangc, 2014/07/07 21:50:09]

Do we still want to sum missing_tiles too? As in adding line:
num_incomplete_tiles += aqd.num_missing_tiles;
?

[danakj, 2014/07/07 21:52:01]

I don't think so, then you'd double count them again cuz you wanna know just how
many tiles were the wrong res for this number right?

[weiliangc, 2014/07/07 21:55:34]

Ah, I forgot the parts after += num_incomplete_tiles need to execute when
missing tiles. Got it. Thanks!

[weiliangc, 2014/07/07 22:01:21]

Done.

+      num_incomplete_tiles += append_quads_data.num_incomplete_tiles;
       frame->contains_incomplete_tile = true;
       if (active_tree()->RequiresHighResToDraw())
         draw_result = DRAW_ABORTED_MISSING_HIGH_RES_CONTENT;
@@ -914,6 +919,15 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(
   // If we're making a frame to draw, it better have at least one render pass.
   DCHECK(!frame->render_passes.empty());
 
+  if (IsCurrentlyScrolling()) {
+    UMA_HISTOGRAM_COUNTS(
+        "Compositing.RenderPass.AppendQuadData.NumMissingTiles",
+        num_missing_tiles);
+    UMA_HISTOGRAM_COUNTS_100(
+        "Compositing.RenderPass.AppendQuadData.NumIncompleteTiles",
+        num_incomplete_tiles);
+  }
+
   // Should only have one render pass in resourceless software mode.
   if (output_surface_->ForcedDrawToSoftwareDevice())
     DCHECK_EQ(1u, frame->render_passes.size());