Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 364043002: Temporarily disable WebView fullscreen video tests until we land fullscreen IPC changes (Closed)

Created:
6 years, 5 months ago by qinmin
Modified:
6 years, 5 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org, Ignacio Solla
Project:
chromium
Visibility:
Public.

Description

Temporarily disable WebView fullscreen video tests until we land fullscreen IPC changes there are 2 changes needs to be submitted before we reenable the tests: 1. https://codereview.chromium.org/290643005/ and 2. https://codereview.chromium.org/292573004/ the blink change will break all the tests, so we need to reenable the tests after the chromium change lands BUG=367346 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenVideoTest.java View 5 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
qinmin
PTAL
6 years, 5 months ago (2014-07-02 21:44:06 UTC) #1
boliu
+igsolla fyi lgtm
6 years, 5 months ago (2014-07-02 21:46:14 UTC) #2
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 5 months ago (2014-07-02 22:01:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/364043002/1
6 years, 5 months ago (2014-07-02 22:01:52 UTC) #4
commit-bot: I haz the power
Change committed as 281165
6 years, 5 months ago (2014-07-03 03:48:33 UTC) #5
qinmin
6 years, 5 months ago (2014-07-09 16:34:10 UTC) #6
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/383433002/ by qinmin@chromium.org.

The reason for reverting is: revert this as all related CLs are submitted.

Powered by Google App Engine
This is Rietveld 408576698