Move typed_data library to external/patch split instead of having an entire separate dart2js librar…

Move typed_data library to external/patch split instead of having an entire separate dart2js library.

R=floitsch@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38112

[Lasse Reichstein Nielsen, 2014-07-03 12:32:12]

https://codereview.chromium.org/363883004/diff/40001/sdk/lib/_internal/lib/na...
File sdk/lib/_internal/lib/native_typed_data.dart (right):

https://codereview.chromium.org/363883004/diff/40001/sdk/lib/_internal/lib/na...
sdk/lib/_internal/lib/native_typed_data.dart:1320:
NativeFloat32x4.fromInt32x4Bits(NativeInt32x4 x) {
It looks wrong (heck, it is wrong) to expect a NativeInt32x4 here, and not any
Int32x4, but it's *no different from the existing code* - except that it's now
also a type error to use another implementation of Int32x4, instead of it just
not having a _storage member.

(I.e., this is bad, but it was already bad, and this CL is not trying to fix it
- it just happens to make it more visible).

https://codereview.chromium.org/363883004/diff/40001/sdk/lib/_internal/lib/ty...
File sdk/lib/_internal/lib/typed_data_patch.dart (right):

https://codereview.chromium.org/363883004/diff/40001/sdk/lib/_internal/lib/ty...
sdk/lib/_internal/lib/typed_data_patch.dart:16: @patch factory ByteData(int
length) =>
I would use "= NativeByteData;", but that fails in the compiler.
Try Patch Set 2 to see the problem.

[floitsch, 2014-07-03 14:14:29]

LGTM.

[Søren Gjesse, 2014-07-04 09:45:22]

LGTM!

[Lasse Reichstein Nielsen, 2014-07-10 09:01:06]

Committed patchset #3 manually as r38112 (presubmit successful).

[sra1, 2014-07-18 17:36:34]

This CL regresses many benchmarks:
Misc/Box2D benchmarks by 8-9%
MeshDecompression by 2.5%
Sudoku by 6%

[floitsch, 2014-07-18 17:39:19]

On 2014/07/18 17:36:34, sra1 wrote:
> This CL regresses many benchmarks:
> Misc/Box2D benchmarks by 8-9%
> MeshDecompression by 2.5%
> Sudoku by 6%

I guess it's for the same reason as http://dartbug.com/20012.