Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 363883003: Fix result status of rerun flaky tests. (Closed)

Created:
6 years, 5 months ago by Michael Achenbach
Modified:
6 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix result status of rerun flaky tests. Tests that pass on reruns where wrongly treated as failures. Now the result state can include any of (PASS, FAIL, CRASH, TIMEOUT) BUG=374134 LOG=n R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M tools/testrunner/local/progress.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/testrunner/local/testsuite.py View 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 5 months ago (2014-07-03 09:19:48 UTC) #1
Jakob Kummerow
lgtm
6 years, 5 months ago (2014-07-03 09:23:36 UTC) #2
Michael Achenbach
6 years, 5 months ago (2014-07-03 09:33:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22186 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698