Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: tools/testrunner/local/testsuite.py

Issue 363883003: Fix result status of rerun flaky tests. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testrunner/local/progress.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testrunner/local/testsuite.py
diff --git a/tools/testrunner/local/testsuite.py b/tools/testrunner/local/testsuite.py
index ff51196a563e4b5607c90f0436b0f1fc67dd9bbc..0fd3f3a3000a35ac2c06549b36e7c4cecd907e80 100644
--- a/tools/testrunner/local/testsuite.py
+++ b/tools/testrunner/local/testsuite.py
@@ -190,18 +190,19 @@ class TestSuite(object):
else:
return execution_failed
- def HasUnexpectedOutput(self, testcase):
+ def GetOutcome(self, testcase):
if testcase.output.HasCrashed():
- outcome = statusfile.CRASH
+ return statusfile.CRASH
elif testcase.output.HasTimedOut():
- outcome = statusfile.TIMEOUT
+ return statusfile.TIMEOUT
elif self.HasFailed(testcase):
- outcome = statusfile.FAIL
+ return statusfile.FAIL
else:
- outcome = statusfile.PASS
- if not testcase.outcomes:
- return outcome != statusfile.PASS
- return not outcome in testcase.outcomes
+ return statusfile.PASS
+
+ def HasUnexpectedOutput(self, testcase):
+ outcome = self.GetOutcome(testcase)
+ return not outcome in (testcase.outcomes or [statusfile.PASS])
def StripOutputForTransmit(self, testcase):
if not self.HasUnexpectedOutput(testcase):
« no previous file with comments | « tools/testrunner/local/progress.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698