Issue 363613003: Removing using declarations that import names in the C++ Standard library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 363613003: Removing using declarations that import names in the C++ Standard library. (Closed)

Created:
6 years, 5 months ago by Sunil Ratnu

Modified:
6 years, 5 months ago

Reviewers:
tkent

CC:
blink-reviews, Raymond Toy

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Removing using declarations that import names in the C++ Standard library. This is as per the the coding guidelines for blink, which disallows the use of "using" declarations of any kind to import names in the C++ Standard library. This is in continuation of the CL https://codereview.chromium.org/334593005/ Effected Folders: Source/modules/ BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177345

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -55 lines)			Patch
M	Source/modules/webaudio/AudioBufferSourceNode.cpp	View	5 chunks	+9 lines, -11 lines	0 comments	Download
M	Source/modules/webaudio/AudioNodeInput.cpp	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	Source/modules/webaudio/AudioParamTimeline.cpp	View	4 chunks	+6 lines, -8 lines	0 comments	Download
M	Source/modules/webaudio/AudioScheduledSourceNode.cpp	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	Source/modules/webaudio/AudioSummingJunction.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/modules/webaudio/DelayDSPKernel.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/modules/webaudio/OfflineAudioDestinationNode.cpp	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	Source/modules/webaudio/OscillatorNode.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/modules/webaudio/PannerNode.cpp	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	Source/modules/webaudio/RealtimeAnalyser.cpp	View	6 chunks	+6 lines, -8 lines	0 comments	Download
M	Source/modules/webaudio/WaveShaperDSPKernel.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/modules/websockets/MainThreadWebSocketChannel.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/modules/websockets/WebSocketFrame.cpp	View	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/363613003/1

6 years, 5 months ago (2014-07-01 22:40:06 UTC) #3

Message was sent while issue was closed.

Change committed as 177345

Expand Messages | Collapse Messages