Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 363543002: Properly handle initialization failure and following manager shutdown without (Closed)

Created:
6 years, 5 months ago by haitaol1
Modified:
6 years, 5 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Properly handle initialization failure and following manager shutdown without crashing. BUG=388948 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281416

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -36 lines) Patch
M sync/internal_api/sync_backup_manager.cc View 1 1 chunk +9 lines, -4 lines 0 comments Download
M sync/internal_api/sync_backup_manager_unittest.cc View 6 chunks +61 lines, -12 lines 0 comments Download
M sync/internal_api/sync_rollback_manager.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_base.h View 2 chunks +6 lines, -0 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_base.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_unittest.cc View 9 chunks +59 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
haitaol1
6 years, 5 months ago (2014-06-30 23:45:16 UTC) #1
haitaol1
ping
6 years, 5 months ago (2014-07-01 22:50:43 UTC) #2
haitaol1
6 years, 5 months ago (2014-07-01 23:26:07 UTC) #3
Nicolas Zea
https://codereview.chromium.org/363543002/diff/1/sync/internal_api/sync_backup_manager.cc File sync/internal_api/sync_backup_manager.cc (right): https://codereview.chromium.org/363543002/diff/1/sync/internal_api/sync_backup_manager.cc#newcode53 sync/internal_api/sync_backup_manager.cc:53: if (initialized()) { nit: I find it clear to ...
6 years, 5 months ago (2014-07-02 18:48:08 UTC) #4
haitaol1
https://codereview.chromium.org/363543002/diff/1/sync/internal_api/sync_backup_manager_unittest.cc File sync/internal_api/sync_backup_manager_unittest.cc (right): https://codereview.chromium.org/363543002/diff/1/sync/internal_api/sync_backup_manager_unittest.cc#newcode35 sync/internal_api/sync_backup_manager_unittest.cc:35: MOCK_METHOD1(OnSyncCycleCompleted, Only intereested in OnInitializationComplete but need to declare ...
6 years, 5 months ago (2014-07-02 20:52:54 UTC) #5
Nicolas Zea
I see, LGTM with the nit I mentioned
6 years, 5 months ago (2014-07-02 21:00:37 UTC) #6
haitaol1
https://codereview.chromium.org/363543002/diff/1/sync/internal_api/sync_backup_manager.cc File sync/internal_api/sync_backup_manager.cc (right): https://codereview.chromium.org/363543002/diff/1/sync/internal_api/sync_backup_manager.cc#newcode53 sync/internal_api/sync_backup_manager.cc:53: if (initialized()) { On 2014/07/02 18:48:07, Nicolas Zea wrote: ...
6 years, 5 months ago (2014-07-02 21:42:18 UTC) #7
haitaol1
The CQ bit was checked by haitaol@chromium.org
6 years, 5 months ago (2014-07-04 15:26:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/363543002/20001
6 years, 5 months ago (2014-07-04 15:26:45 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-04 17:01:27 UTC) #10
Message was sent while issue was closed. 
Change committed as 281416

Powered by Google App Engine
This is Rietveld 408576698