Properly handle initialization failure and following manager shutdown without

sync/internal_api/sync_backup_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/internal_api/sync_backup_manager.h"
 
 #include "sync/internal_api/public/read_node.h"
 #include "sync/internal_api/public/write_transaction.h"
 #include "sync/syncable/directory.h"
 #include "sync/syncable/mutable_entry.h"
@@ skipping 32 matching lines @@
                                 use_ssl, post_factory.Pass(),
                                 workers, extensions_activity, change_delegate,
                                 credentials, invalidator_client_id,
                                 restored_key_for_bootstrapping,
                                 restored_keystore_key_for_bootstrapping,
                                 internal_components_factory, encryptor,
                                 unrecoverable_error_handler.Pass(),
                                 report_unrecoverable_error_function,
                                 cancelation_signal);
 
-  GetUserShare()->directory->CollectMetaHandleCounts(
+  if (initialized()) {

[Nicolas Zea, 2014/07/02 18:48:07]

nit: I find it clear to do if (!initialized()) return here and below.

[haitaol1, 2014/07/02 21:42:18]

Done.

+    GetUserShare()->directory->CollectMetaHandleCounts(
       &status_.num_entries_by_type,
       &status_.num_to_delete_entries_by_type);
 
-  HideSyncPreference(PRIORITY_PREFERENCES);
-  HideSyncPreference(PREFERENCES);
+    HideSyncPreference(PRIORITY_PREFERENCES);
+    HideSyncPreference(PREFERENCES);
+  }
 }
 
 void SyncBackupManager::SaveChanges() {
-  NormalizeEntries();
-  GetUserShare()->directory->SaveChanges();
+  if (initialized()) {
+    NormalizeEntries();
+    GetUserShare()->directory->SaveChanges();
+  }
 }
 
 SyncStatus SyncBackupManager::GetDetailedStatus() const {
   return status_;
 }
 
 ModelTypeSet SyncBackupManager::HandleTransactionEndingChangeEvent(
     const syncable::ImmutableWriteTransactionInfo& write_transaction_info,
     syncable::BaseTransaction* trans) {
   ModelTypeSet types;
@@ skipping 76 matching lines @@
 
 void SyncBackupManager::UnregisterDirectoryTypeDebugInfoObserver(
     syncer::TypeDebugInfoObserver* observer) {}
 
 bool SyncBackupManager::HasDirectoryTypeDebugInfoObserver(
     syncer::TypeDebugInfoObserver* observer) { return false; }
 
 void SyncBackupManager::RequestEmitDebugInfo() {}
 
 }  // namespace syncer