Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1615)

Issue 363323003: More OStreamsUse OStreams more often. (Closed)

Created:
6 years, 5 months ago by Sven Panne
Modified:
6 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

More OStreamsUse OStreams more often. This is a mostly mechanical CL (more than 90% Emacs macros and query-replace-regexp) moving FILE*/StringStream*-based APIs to OStream-based APIs. There are a few places where this had to stop, otherwise the CL would be even bigger, but this can easily and incrementally cleaned up later. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22232

Patch Set 1 #

Patch Set 2 : Rebased and polished. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2108 lines, -2304 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/arm64/simulator-arm64.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +12 lines, -15 lines 0 comments Download
M src/ast.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/ast.cc View 5 chunks +40 lines, -49 lines 0 comments Download
M src/builtins.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M src/codegen.cc View 1 2 chunks +13 lines, -16 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M src/elements-kind.h View 2 chunks +1 line, -1 line 0 comments Download
M src/elements-kind.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/flags.cc View 1 4 chunks +43 lines, -46 lines 0 comments Download
M src/frames.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/gdb-jit.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/heap.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M src/hydrogen.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 1 8 chunks +41 lines, -56 lines 0 comments Download
M src/hydrogen-gvn.h View 6 chunks +20 lines, -3 lines 0 comments Download
M src/hydrogen-gvn.cc View 1 7 chunks +34 lines, -55 lines 0 comments Download
M src/hydrogen-instructions.h View 102 chunks +209 lines, -185 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 31 chunks +326 lines, -440 lines 0 comments Download
M src/hydrogen-types.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/hydrogen-types.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ic.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/jsregexp.cc View 8 chunks +102 lines, -110 lines 0 comments Download
M src/objects.h View 1 20 chunks +45 lines, -26 lines 0 comments Download
M src/objects.cc View 1 20 chunks +250 lines, -237 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects-printer.cc View 1 13 chunks +577 lines, -728 lines 0 comments Download
M src/ostreams.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/ostreams.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/property.h View 1 5 chunks +9 lines, -11 lines 0 comments Download
M src/property.cc View 1 1 chunk +22 lines, -34 lines 0 comments Download
M src/runtime.cc View 1 5 chunks +29 lines, -24 lines 0 comments Download
M src/safepoint-table.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/safepoint-table.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M src/spaces.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/stub-cache.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/transitions.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/typing.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 17 chunks +34 lines, -17 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 7 chunks +14 lines, -7 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-regexp.cc View 8 chunks +153 lines, -152 lines 0 comments Download
M test/cctest/test-symbols.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Benedikt Meurer
LGTM (rubber-stamped)
6 years, 5 months ago (2014-07-07 09:06:43 UTC) #1
Sven Panne
6 years, 5 months ago (2014-07-07 09:58:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r22232 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698