Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: src/property.h

Issue 363323003: More OStreamsUse OStreams more often. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased and polished. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ostreams.cc ('k') | src/property.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/property.h
diff --git a/src/property.h b/src/property.h
index c50696b186b241d5af77dc8731a13f59c64d5102..2c05188359b9f4c3fd1cb335457153bd8e1c8e9a 100644
--- a/src/property.h
+++ b/src/property.h
@@ -9,6 +9,7 @@
#include "src/field-index.h"
#include "src/field-index-inl.h"
#include "src/isolate.h"
+#include "src/ostreams.h"
#include "src/types.h"
namespace v8 {
@@ -28,13 +29,9 @@ class Descriptor BASE_EMBEDDED {
}
}
- Handle<Name> GetKey() { return key_; }
- Handle<Object> GetValue() { return value_; }
- PropertyDetails GetDetails() { return details_; }
-
-#ifdef OBJECT_PRINT
- void Print(FILE* out);
-#endif
+ Handle<Name> GetKey() const { return key_; }
+ Handle<Object> GetValue() const { return value_; }
+ PropertyDetails GetDetails() const { return details_; }
void SetSortedKeyIndex(int index) { details_ = details_.set_pointer(index); }
@@ -72,6 +69,9 @@ class Descriptor BASE_EMBEDDED {
};
+OStream& operator<<(OStream& os, const Descriptor& d);
+
+
class FieldDescriptor V8_FINAL : public Descriptor {
public:
FieldDescriptor(Handle<Name> key,
@@ -408,10 +408,6 @@ class LookupResult V8_FINAL BASE_EMBEDDED {
return GetValue();
}
-#ifdef OBJECT_PRINT
- void Print(FILE* out);
-#endif
-
Object* GetValue() const {
if (lookup_type_ == DESCRIPTOR_TYPE) {
return GetValueFromMap(holder()->map());
@@ -487,6 +483,8 @@ class LookupResult V8_FINAL BASE_EMBEDDED {
PropertyDetails details_;
};
+
+OStream& operator<<(OStream& os, const LookupResult& r);
} } // namespace v8::internal
#endif // V8_PROPERTY_H_
« no previous file with comments | « src/ostreams.cc ('k') | src/property.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698