Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 363283002: Revert "Delete paint invalidaiton code in RenderLayerModelObject::styleWillChange." (Closed)

Created:
6 years, 5 months ago by lushnikov
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Revert "Delete paint invalidaiton code in RenderLayerModelObject::styleWillChange." The revert of https://codereview.chromium.org/360193002 Reason of revert: The following tests failures css3/flexbox/repaint-opacity-change.html fast/repaint/fixed-and-absolute-position-scrolled.html The actual test expectations look like regression. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=css3/flexbox/repaint-opacity-change.html,fast/repaint/fixed-and-absolute-position-scrolled.html BUG=391036 TBR=chrishtr,pilgrim@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -35 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
D LayoutTests/fast/repaint/paint-invalidation-with-opacity.html View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/repaint/paint-invalidation-with-opacity-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M LayoutTests/platform/linux/fast/repaint/create-layer-repaint-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/linux/fast/repaint/positioned-document-element-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerModelObject.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
lushnikov
6 years, 5 months ago (2014-07-03 08:36:37 UTC) #1
lushnikov
6 years, 5 months ago (2014-07-03 08:37:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r177460 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698