Delete paint invalidaiton code in RenderLayerModelObject::styleWillChange.

Delete paint invalidaiton code in RenderLayerModelObject::styleWillChange.

This code should not be necessary, these cases are handled by the mainline
repaint-after-layout machinery.

BUG=391036
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177431

[chrishtr, 2014-07-01 03:50:35]

I don't see why this code is necessary. Repaint after layout code should handle
it already. Deleting the code caused paint invalidation changes that were only
removing duplicate invalidations.

https://codereview.chromium.org/247713003 removed some of the invalidations
there, and looks like the more relevant recent CL.

[Xianzhu, 2014-07-01 16:27:32]

On 2014/07/01 03:50:35, chrishtr wrote:
> I don't see why this code is necessary. Repaint after layout code should
handle
> it already. Deleting the code caused paint invalidation changes that were only
> removing duplicate invalidations.
> 
> https://codereview.chromium.org/247713003 removed some of the invalidations
> there, and looks like the more relevant recent CL.

The code might be needed when RAL was not enabled and old path was not removed.
Thanks for cleaning up this.

Can you add a test case covering this? The existing
fast/repaint/create-layer-repaint.html may be related, but its repaintTest also
changes the background-color of the target which will trigger repaint in another
path. I think we need a test that changes opacity only to cover the changed
code.

[chrishtr, 2014-07-02 04:33:08]

On 2014/07/01 16:27:32, Xianzhu wrote:
> On 2014/07/01 03:50:35, chrishtr wrote:
> > I don't see why this code is necessary. Repaint after layout code should
> handle
> > it already. Deleting the code caused paint invalidation changes that were
only
> > removing duplicate invalidations.
> > 
> > https://codereview.chromium.org/247713003 removed some of the invalidations
> > there, and looks like the more relevant recent CL.
> 
> The code might be needed when RAL was not enabled and old path was not
removed.
> Thanks for cleaning up this.
> 
> Can you add a test case covering this? The existing
> fast/repaint/create-layer-repaint.html may be related, but its repaintTest
also
> changes the background-color of the target which will trigger repaint in
another
> path. I think we need a test that changes opacity only to cover the changed
> code.

Added a test specifically for opacity.

[dsinclair, 2014-07-02 13:33:35]

lgtm

[Xianzhu, 2014-07-02 16:10:37]

lgtm

[leviw_travelin_and_unemployed, 2014-07-02 17:46:49]

Enthusiastic LGTM!

[chrishtr, 2014-07-02 17:47:00]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-07-02 17:47:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishtr@chromium.org/360193002/100001

[commit-bot: I haz the power, 2014-07-02 18:53:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/13989)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/15119)

[commit-bot: I haz the power, 2014-07-02 19:27:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 19:27:29]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/14001)

[chrishtr, 2014-07-02 19:48:54]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-07-02 19:49:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishtr@chromium.org/360193002/120001

[commit-bot: I haz the power, 2014-07-02 20:55:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/14009)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/28657)

[commit-bot: I haz the power, 2014-07-02 20:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 20:56:28]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/14014)

[chrishtr, 2014-07-02 21:11:26]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-07-02 21:12:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishtr@chromium.org/360193002/140001

[commit-bot: I haz the power, 2014-07-02 22:16:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/15157)

[commit-bot: I haz the power, 2014-07-02 22:48:26]

Change committed as 177431

[lushnikov, 2014-07-03 11:06:53]

On 2014/07/02 22:48:26, I haz the power (commit-bot) wrote:
> Change committed as 177431

A revert of this patch was landed: https://codereview.chromium.org/363283002