Encapsulate FontFallbackList's page access logic.

Encapsulate FontFallbackList's page access logic.

Minor cleanup: add a getter & setter to avoid code duplication in
Font.cpp.

R=jbroman@chormium.org,eae@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177397

[jbroman, 2014-07-02 12:46:45]

lgtm with nits

https://codereview.chromium.org/362963003/diff/1/Source/platform/fonts/FontFa...
File Source/platform/fonts/FontFallbackList.h (right):

https://codereview.chromium.org/362963003/diff/1/Source/platform/fonts/FontFa...
Source/platform/fonts/FontFallbackList.h:122: mutable GlyphPages m_pages;
nit: Any reason for these two members to be mutable? (I realize they were this
way before, but since you're looking at this...).

https://codereview.chromium.org/362963003/diff/1/Source/platform/fonts/FontFa...
Source/platform/fonts/FontFallbackList.h:133: friend class Font;
nit: How about making these two methods public and removing this friendship?

[f(malita), 2014-07-02 13:07:30]

https://codereview.chromium.org/362963003/diff/1/Source/platform/fonts/FontFa...
File Source/platform/fonts/FontFallbackList.h (right):

https://codereview.chromium.org/362963003/diff/1/Source/platform/fonts/FontFa...
Source/platform/fonts/FontFallbackList.h:122: mutable GlyphPages m_pages;
On 2014/07/02 12:46:44, jbroman wrote:
> nit: Any reason for these two members to be mutable? (I realize they were this
> way before, but since you're looking at this...).

I totally meant to do this and then forgot :) Done.

https://codereview.chromium.org/362963003/diff/1/Source/platform/fonts/FontFa...
Source/platform/fonts/FontFallbackList.h:133: friend class Font;
On 2014/07/02 12:46:44, jbroman wrote:
> nit: How about making these two methods public and removing this friendship?

Font.cpp is also using a couple of other private methods, not just the page
accessors -- so we need to promote those too in order to break the friendship.
Updated, PTAL.

[jbroman, 2014-07-02 14:16:31]

lgtm

[f(malita), 2014-07-02 14:25:45]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2014-07-02 14:26:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fmalita@chromium.org/362963003/20001

[commit-bot: I haz the power, 2014-07-02 15:15:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/15078)

[eae, 2014-07-02 15:53:10]

LGTM

[commit-bot: I haz the power, 2014-07-02 16:04:28]

Change committed as 177397