Encapsulate FontFallbackList's page access logic.

Source/platform/fonts/FontFallbackList.h

 /*
  * Copyright (C) 2006, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 87 matching lines @@
         return m_cachedPrimarySimpleFontData;
     }
 
     PassRefPtr<FontData> getFontData(const FontDescription&, int& familyIndex) const;
 
     const SimpleFontData* determinePrimarySimpleFontData(const FontDescription&) const;
     const FontData* fontDataAt(const FontDescription&, unsigned index) const;
 
     void releaseFontData();
 
+    GlyphPageTreeNode* getPageNode(unsigned pageNumber) const
+    {
+        return pageNumber ? m_pages.get(pageNumber) : m_pageZero;
+    }
+
+    void setPageNode(unsigned pageNumber, GlyphPageTreeNode* node)
+    {
+        if (pageNumber)
+            m_pages.set(pageNumber, node);
+        else
+            m_pageZero = node;
+    }
+
     mutable Vector<RefPtr<FontData>, 1> m_fontList;
     mutable GlyphPages m_pages;

[jbroman, 2014/07/02 12:46:44]

nit: Any reason for these two members to be mutable? (I realize they were this
way before, but since you're looking at this...).

[f(malita), 2014/07/02 13:07:30]

I totally meant to do this and then forgot :) Done.

     mutable GlyphPageTreeNode* m_pageZero;
     mutable const SimpleFontData* m_cachedPrimarySimpleFontData;
     RefPtrWillBePersistent<FontSelector> m_fontSelector;
     mutable WidthCache m_widthCache;
     unsigned m_fontSelectorVersion;
     mutable int m_familyIndex;
     unsigned short m_generation;
     mutable unsigned m_pitch : 3; // Pitch
     mutable bool m_hasLoadingFallback : 1;
 
     friend class Font;

[jbroman, 2014/07/02 12:46:44]

nit: How about making these two methods public and removing this friendship?

[f(malita), 2014/07/02 13:07:30]

Font.cpp is also using a couple of other private methods, not just the page
accessors -- so we need to promote those too in order to break the friendship.
Updated, PTAL.

 };
 
 }
 
 #endif