Move transformationForTextBox() call out of the fragment-loop

Move transformationForTextBox() call out of the fragment-loop

textBox is invariant, so no need to fetch and check the transform for each
fragment.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177517

[pdr., 2014-07-03 22:56:50]

LGTM.

https://codereview.chromium.org/362923007/diff/1/Source/core/rendering/svg/SV...
File Source/core/rendering/svg/SVGTextLayoutEngine.cpp (right):

https://codereview.chromium.org/362923007/diff/1/Source/core/rendering/svg/SV...
Source/core/rendering/svg/SVGTextLayoutEngine.cpp:298:
m_chunkLayoutBuilder.transformationForTextBox(textBox, textBoxTransformation);
What do you think about refactoring this function to just return the
textBoxTransform instead of using an out param?

[fs, 2014-07-04 07:51:31]

On 2014/07/03 22:56:50, pdr wrote:
> LGTM.
> 
>
https://codereview.chromium.org/362923007/diff/1/Source/core/rendering/svg/SV...
> File Source/core/rendering/svg/SVGTextLayoutEngine.cpp (right):
> 
>
https://codereview.chromium.org/362923007/diff/1/Source/core/rendering/svg/SV...
> Source/core/rendering/svg/SVGTextLayoutEngine.cpp:298:
> m_chunkLayoutBuilder.transformationForTextBox(textBox, textBoxTransformation);
> What do you think about refactoring this function to just return the
> textBoxTransform instead of using an out param?

Yeah, I pondered doing that too. Will do that as a follow-up.

[fs, 2014-07-04 07:51:35]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-07-04 07:52:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fs@opera.com/362923007/1

[commit-bot: I haz the power, 2014-07-04 07:56:18]

Change committed as 177517