Move transformationForTextBox() call out of the fragment-loop

Source/core/rendering/svg/SVGTextLayoutEngine.cpp

 /*
  * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 277 matching lines @@
 
 void SVGTextLayoutEngine::finalizeTransformMatrices(Vector<SVGInlineTextBox*>& boxes)
 {
     unsigned boxCount = boxes.size();
     if (!boxCount)
         return;
 
     AffineTransform textBoxTransformation;
     for (unsigned boxPosition = 0; boxPosition < boxCount; ++boxPosition) {
         SVGInlineTextBox* textBox = boxes.at(boxPosition);
+        m_chunkLayoutBuilder.transformationForTextBox(textBox, textBoxTransformation);

[pdr., 2014/07/03 22:56:49]

What do you think about refactoring this function to just return the
textBoxTransform instead of using an out param?

+        if (textBoxTransformation.isIdentity())
+            continue;
+
         Vector<SVGTextFragment>& fragments = textBox->textFragments();
-
         unsigned fragmentCount = fragments.size();
         for (unsigned i = 0; i < fragmentCount; ++i) {
-            m_chunkLayoutBuilder.transformationForTextBox(textBox, textBoxTransformation);
-            if (textBoxTransformation.isIdentity())
-                continue;
             ASSERT(fragments[i].lengthAdjustTransform.isIdentity());
             fragments[i].lengthAdjustTransform = textBoxTransformation;
         }
     }
 
     boxes.clear();
 }
 
 void SVGTextLayoutEngine::finishLayout()
 {
@@ skipping 330 matching lines @@
     }
 
     if (!didStartTextFragment)
         return;
 
     // Close last open fragment, if needed.
     recordTextFragment(textBox, visualMetricsValues);
 }
 
 }