Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 362863002: Add future sync point methods to ContextSupport. (Closed)

Created:
6 years, 5 months ago by jbauman
Modified:
6 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Add future sync point methods to ContextSupport. This way they can be used by the compositor or another consumer. BUG=365454 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283372

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
M cc/test/test_context_support.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/test/test_context_support.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
A gpu/GLES2/extensions/CHROMIUM/CHROMIUM_future_sync_point.txt View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/context_support.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jbauman
6 years, 5 months ago (2014-07-11 20:40:48 UTC) #1
piman
lgtm https://codereview.chromium.org/362863002/diff/20001/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_sync_point.txt File gpu/GLES2/extensions/CHROMIUM/CHROMIUM_sync_point.txt (right): https://codereview.chromium.org/362863002/diff/20001/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_sync_point.txt#newcode59 gpu/GLES2/extensions/CHROMIUM/CHROMIUM_sync_point.txt:59: a context is "trusted", which is defined by ...
6 years, 5 months ago (2014-07-11 22:24:32 UTC) #2
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 5 months ago (2014-07-15 20:57:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/362863002/40001
6 years, 5 months ago (2014-07-15 21:01:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 01:29:41 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 01:52:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/170725)
6 years, 5 months ago (2014-07-16 01:52:42 UTC) #7
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 5 months ago (2014-07-16 05:59:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/362863002/40001
6 years, 5 months ago (2014-07-16 06:00:26 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-16 06:06:31 UTC) #10
Message was sent while issue was closed.
Change committed as 283372

Powered by Google App Engine
This is Rietveld 408576698